Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server/api): private data in api call #8019

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

stephane-m-dev
Copy link
Contributor

Description

API call: vm.importMultipleFromEsxi loggued in the task view contains the login/password in params.
This fix obfuscate the password.

https://help.vates.tech/#ticket/zoom/23349

XO-134

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@velvetrevolver velvetrevolver force-pushed the fix-private-data-in-api-call branch 4 times, most recently from bef77bf to 80f40b5 Compare September 27, 2024 08:51
@stephane-m-dev stephane-m-dev requested review from fbeauchamp and MathieuRA and removed request for b-Nollet September 27, 2024 09:34
@MathieuRA MathieuRA merged commit 939ab29 into master Sep 27, 2024
1 check passed
@MathieuRA MathieuRA deleted the fix-private-data-in-api-call branch September 27, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants